feat(binding_coap)!: remove support for cov:observe subprotocol #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
coap-observe-subprotocol
branch
from
7ac5a64 to
44059a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 62.95% 63.16% +0.20%
==========================================
Files 79 79
Lines 2319 2305 -14
==========================================
- Hits 1460 1456 -4
+ Misses 859 849 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via w3c/wot-binding-templates#353, the
cov:observesubprotocol has been removed from the CoAP binding template. This PR incorporates these changes by removing the code related to the now outdated subprotocol.Currently, the polling behavior that is supposed to be used as a fallback as described in the binding template is not really supported yet, but I think this is something that should rather be added to the underlying CoAP library. I will investigate this in future PRs :)